chrome/renderer/chrome_content_renderer_client.cc - Issue 23007021: Report Javascript Runtime Errors to the Error Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_host.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 1fa7a9cc91667b06716abe8facba1a0671e46219..6466975a1624bed8006459c728330ce6c10c0d75 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -1301,7 +1301,7 @@ bool ChromeContentRendererClient::AllowPepperMediaStreamAPI(

bool ChromeContentRendererClient::ShouldReportDetailedMessageForSource(

const base::string16& source) const {

- return GURL(source).SchemeIs(extensions::kExtensionScheme);

+ return extensions::IsSourceFromAnExtension(source);

}

} // namespace chrome