content/browser/web_contents/web_contents_impl.cc - Issue 23007021: Report Javascript Runtime Errors to the Error Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_host.cc ('K') | « chrome/test/data/extensions/error_console/content_script_log_and_runtime_error/manifest.json ('k') | content/public/browser/web_contents_observer.h » ('j') | extensions/browser/extension_error.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 7d999ec0c09d06191eaf7a5df81f225e8253fdfa..5a58cb219ea0f08324abaade9354e8eec5b3d553 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3427,6 +3427,14 @@ bool WebContentsImpl::AddMessageToConsole(int32 level,

int32 line_no,

const string16& source_id,

const string16& stack_trace) {

+ FOR_EACH_OBSERVER(WebContentsObserver,

Devlin 2013/08/23 20:06:51 Cris - RenderViewHostImpl receives the IPC message

+ observers_,

+ OnMessageAddedToConsole(

+ source_id,

+ message,

+ stack_trace,

+ line_no,

+ static_cast<logging::LogSeverity>(level)));

if (!delegate_)

return false;

return delegate_->AddMessageToConsole(this, level, message, line_no,