Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8497)

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/tab_helper.cc
diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc
index ac7620c4440e913eda0cd8664c35a0196566ac0f..2ef5dff33f65ffd72a2d7f1ac791610673b9cfa8 100644
--- a/chrome/browser/extensions/tab_helper.cc
+++ b/chrome/browser/extensions/tab_helper.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
#include "chrome/browser/extensions/api/declarative_content/content_rules_registry.h"
#include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/error_console/error_console.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_manager.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -45,6 +46,8 @@
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_view.h"
+#include "extensions/browser/extension_error.h"
+#include "extensions/common/constants.h"
#include "extensions/common/extension_resource.h"
#include "ui/gfx/image/image.h"
@@ -253,6 +256,24 @@ void TabHelper::DidCloneToNewWebContents(WebContents* old_web_contents,
new_helper->extension_app_icon_ = extension_app_icon_;
}
+void TabHelper::OnMessageAddedToConsole(const base::string16& source,
+ const base::string16& message,
+ const base::string16& stack_trace,
+ int32 line_number,
+ logging::LogSeverity level) {
+ if (IsSourceFromAnExtension(source)) {
+ ErrorConsole::Get(profile_)->ReportError(
+ scoped_ptr<const ExtensionError>(new JavascriptRuntimeError(
+ profile_->IsOffTheRecord(),
+ source,
+ message,
+ stack_trace,
+ line_number,
+ web_contents() ?
+ web_contents()->GetLastCommittedURL() : GURL::EmptyGURL(),
+ level)));
+ }
+}
void TabHelper::OnDidGetApplicationInfo(int32 page_id,
const WebApplicationInfo& info) {

Powered by Google App Engine
This is Rietveld 408576698