Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2300663002: Fix for crash in GuestViewBase::FindReply. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for crash in GuestViewBase::FindReply. There are two problems here: 1) The GuestViewBase received a FindReply while its WebContents was in the process of being destroyed. This patch adds a check in WebContentsImpl::NotifyFindReply to prevent this. 2) During destruction of GuestViewBase, there is a period of time when there is no owner WebContents, but attached() still returns true. This patch ensures that that attached() will return false as soon as |owner_web_contents_| is cleared. BUG=642733 Committed: https://crrev.com/60b5d837275657c6d1cd0e110c833851b8d154ad Cr-Commit-Position: refs/heads/master@{#415697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/guest_view/browser/guest_view_base.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
paulmeyer
+nick@
4 years, 3 months ago (2016-08-31 16:11:16 UTC) #2
ncarter (slow)
lgtm
4 years, 3 months ago (2016-08-31 16:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300663002/1
4 years, 3 months ago (2016-08-31 17:33:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 18:46:51 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:50:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60b5d837275657c6d1cd0e110c833851b8d154ad
Cr-Commit-Position: refs/heads/master@{#415697}

Powered by Google App Engine
This is Rietveld 408576698