Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2300663002: Fix for crash in GuestViewBase::FindReply. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 5098 matching lines...) Expand 10 before | Expand all | Expand 10 after
5109 find_request_manager_.reset(new FindRequestManager(this)); 5109 find_request_manager_.reset(new FindRequestManager(this));
5110 5110
5111 return find_request_manager_.get(); 5111 return find_request_manager_.get();
5112 } 5112 }
5113 5113
5114 void WebContentsImpl::NotifyFindReply(int request_id, 5114 void WebContentsImpl::NotifyFindReply(int request_id,
5115 int number_of_matches, 5115 int number_of_matches,
5116 const gfx::Rect& selection_rect, 5116 const gfx::Rect& selection_rect,
5117 int active_match_ordinal, 5117 int active_match_ordinal,
5118 bool final_update) { 5118 bool final_update) {
5119 if (delegate_) { 5119 if (delegate_ && !is_being_destroyed_) {
5120 delegate_->FindReply(this, request_id, number_of_matches, selection_rect, 5120 delegate_->FindReply(this, request_id, number_of_matches, selection_rect,
5121 active_match_ordinal, final_update); 5121 active_match_ordinal, final_update);
5122 } 5122 }
5123 } 5123 }
5124 5124
5125 void WebContentsImpl::IncrementBluetoothConnectedDeviceCount() { 5125 void WebContentsImpl::IncrementBluetoothConnectedDeviceCount() {
5126 // Trying to invalidate the tab state while being destroyed could result in a 5126 // Trying to invalidate the tab state while being destroyed could result in a
5127 // use after free. 5127 // use after free.
5128 if (IsBeingDestroyed()) { 5128 if (IsBeingDestroyed()) {
5129 return; 5129 return;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
5213 for (RenderViewHost* render_view_host : render_view_host_set) 5213 for (RenderViewHost* render_view_host : render_view_host_set)
5214 render_view_host->OnWebkitPreferencesChanged(); 5214 render_view_host->OnWebkitPreferencesChanged();
5215 } 5215 }
5216 5216
5217 void WebContentsImpl::SetJavaScriptDialogManagerForTesting( 5217 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
5218 JavaScriptDialogManager* dialog_manager) { 5218 JavaScriptDialogManager* dialog_manager) {
5219 dialog_manager_ = dialog_manager; 5219 dialog_manager_ = dialog_manager;
5220 } 5220 }
5221 5221
5222 } // namespace content 5222 } // namespace content
OLDNEW
« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698