Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2300633007: Enable untrusted mousedown on select boxes for webview (Closed)

Created:
4 years, 3 months ago by dtapuska
Modified:
4 years, 3 months ago
CC:
aelias_OOO_until_Jul13, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable untrusted mousedown on select boxes for webview We have found that some webviews are using fastclick inside them and due to a risk of breakage we are going to allow mousedown on selects even if they are untrusted. BUG=642698 Committed: https://crrev.com/0c254feb3c58b5a9223591084e77d093173d582b Cr-Commit-Position: refs/heads/master@{#416330}

Patch Set 1 #

Patch Set 2 : Add bug number for target sdk quirk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dtapuska
4 years, 3 months ago (2016-09-02 16:34:19 UTC) #2
Rick Byers
LGTM Note this is intentionally very minimal in order to permit a merge to M53. ...
4 years, 3 months ago (2016-09-02 16:36:27 UTC) #3
Rick Byers
On 2016/09/02 16:36:27, Rick Byers wrote: > LGTM > Note this is intentionally very minimal ...
4 years, 3 months ago (2016-09-02 16:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300633007/20001
4 years, 3 months ago (2016-09-02 16:42:38 UTC) #8
boliu
On 2016/09/02 16:37:25, Rick Byers wrote: > On 2016/09/02 16:36:27, Rick Byers wrote: > > ...
4 years, 3 months ago (2016-09-02 16:44:15 UTC) #9
aelias_OOO_until_Jul13
lgtm
4 years, 3 months ago (2016-09-02 17:39:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 20:10:35 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 20:13:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c254feb3c58b5a9223591084e77d093173d582b
Cr-Commit-Position: refs/heads/master@{#416330}

Powered by Google App Engine
This is Rietveld 408576698