third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp - Issue 2300633004: Allow canvases to be GPU-accelerated in Workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2300633004: Allow canvases to be GPU-accelerated in Workers (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmap.cpp ('k') | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

index 202212cc1ffdb1fc6624314e2f76e6b1c5b9c310..4ecbc3041d96ff0b88a92f9f4dacfcd55afc1308 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

@@ -83,8 +83,6 @@ bool OffscreenCanvasRenderingContext2D::hasImageBuffer() const

static bool shouldAccelerate(IntSize surfaceSize)

{

- if (!isMainThread())

- return false; // Add support on Workers crbug.com/

return RuntimeEnabledFeatures::accelerated2dCanvasEnabled();

}

@@ -119,7 +117,6 @@ ImageBitmap* OffscreenCanvasRenderingContext2D::transferToImageBitmap(ExceptionS

if (!imageBuffer())

return nullptr;

RefPtr<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(PreferAcceleration, SnapshotReasonTransferToImageBitmap);

- DCHECK(isMainThread() || !skImage->isTextureBacked()); // Acceleration not yet supported in Workers

RefPtr<StaticBitmapImage> image = StaticBitmapImage::create(skImage.release());

image->setOriginClean(this->originClean());

m_imageBuffer.reset(); // "Transfer" means no retained buffer