Add texelFetchOffset walkaround for Intel Mac

Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8
Cr-Commit-Position: refs/heads/master@{#416172}

[jchen10, 2016-08-31 08:26:32]

Description was changed from

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
==========

to

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jchen10, 2016-08-31 08:28:42]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 08:28:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jchen10, 2016-08-31 08:29:44]

Description was changed from

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jchen10, 2016-08-31 08:29:44]

jie.a.chen@intel.com changed reviewers:
+ kbr@chromium.org, qiankun.miao@intel.com, yunchao.he@intel.com,
zmo@chromium.org

[jchen10, 2016-08-31 08:44:39]

Please have a look! Thanks!

[commit-bot: I haz the power, 2016-08-31 09:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 09:43:42]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-31 16:20:40]

On 2016/08/31 08:44:39, jchen10 wrote:
> Please have a look! Thanks!

Jie, Please update the webgl2 conformance test expectation, then the bot will
run that test and show green or red.

[jchen10, 2016-09-01 02:52:32]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 02:52:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 02:54:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jchen10, 2016-09-01 05:45:18]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 06:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:49:44]

Dry run: This issue passed the CQ dry run.

[jchen10, 2016-09-01 06:51:17]

On 2016/08/31 16:20:40, yunchao wrote:
> On 2016/08/31 08:44:39, jchen10 wrote:
> > Please have a look! Thanks!
> 
> Jie, Please update the webgl2 conformance test expectation, then the bot will
> run that test and show green or red.

Done!

[Zhenyao Mo, 2016-09-01 17:04:57]

lgtm
but please rebase against https://codereview.chromium.org/2297603002/

[jchen10, 2016-09-02 01:23:59]

The CQ bit was checked by jie.a.chen@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 01:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 02:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 02:35:56]

Dry run: This issue passed the CQ dry run.

[jchen10, 2016-09-02 02:37:11]

The CQ bit was checked by jie.a.chen@intel.com

[jchen10, 2016-09-02 02:37:11]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2300573002/#ps60001
(title: "Rebase again")

[commit-bot: I haz the power, 2016-09-02 02:37:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 02:41:20]

Description was changed from

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-02 02:41:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 02:44:19]

Description was changed from

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG=642605
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8
Cr-Commit-Position: refs/heads/master@{#416172}
==========

[commit-bot: I haz the power, 2016-09-02 02:44:20]

Patchset 4 (id:??) landed as
https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8
Cr-Commit-Position: refs/heads/master@{#416172}