Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2300423002: Reland of Make TrayDetailsView a ViewClickListener and ButtonListener (Closed)

Created:
4 years, 3 months ago by tdanderson
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, yusukes+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, shuchen+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make TrayDetailsView a ViewClickListener and ButtonListener Reland of https://codereview.chromium.org/2289223002/. Some initial changes in preparation for implementing the material design version of the detailed views in the Ash system menu: * Make TrayDetailsView extend ViewClickListener and ButtonListener instead of having each of TrayDetailsView's subclasses extend these. The aim is to place common code in TrayDetailsView. * Rename the TrayDetailsView "footer row" to be the "title row"; for material design this row appears at the top of the detailed view, not the bottom. * For material design (--ash-md=experimental), show the title row at the top of the detailed view and do not instantiate or show any non-MD buttons in this row. Further improvements to the appearance and functionality of the title rows to be handled in subsequent CLs. BUG=642136 TEST=ash_unittests Committed: https://crrev.com/d3300aeaf3c505a3c7c8e9d79936efe0df60207a Cr-Commit-Position: refs/heads/master@{#416312}

Patch Set 1 #

Patch Set 2 : for review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -274 lines) Patch
M ash/common/system/cast/tray_cast.cc View 6 chunks +16 lines, -25 lines 0 comments Download
M ash/common/system/chromeos/audio/audio_detailed_view.h View 3 chunks +3 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 7 chunks +81 lines, -65 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +19 lines, -19 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.h View 5 chunks +12 lines, -11 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 11 chunks +25 lines, -24 lines 0 comments Download
M ash/common/system/chromeos/network/tray_sms.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M ash/common/system/chromeos/network/vpn_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M ash/common/system/tray/tray_details_view.h View 2 chunks +46 lines, -20 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 5 chunks +46 lines, -21 lines 0 comments Download
M ash/common/system/tray/tray_details_view_unittest.cc View 1 11 chunks +38 lines, -21 lines 1 comment Download
M ash/common/system/tray/view_click_listener.h View 1 chunk +3 lines, -1 line 0 comments Download
M ash/common/system/tray_accessibility.h View 3 chunks +5 lines, -7 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M ui/chromeos/network/network_list_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tdanderson
Oshima, can you please take a look? The only change is in ash/common/system/tray/tray_details_view_unittest.cc (see my ...
4 years, 3 months ago (2016-09-02 15:47:00 UTC) #4
oshima
lgtm
4 years, 3 months ago (2016-09-02 18:52:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300423002/20001
4 years, 3 months ago (2016-09-02 18:56:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 19:05:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 19:08:25 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3300aeaf3c505a3c7c8e9d79936efe0df60207a
Cr-Commit-Position: refs/heads/master@{#416312}

Powered by Google App Engine
This is Rietveld 408576698