Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: ash/common/system/chromeos/network/tray_sms.cc

Issue 2300423002: Reland of Make TrayDetailsView a ViewClickListener and ButtonListener (Closed)
Patch Set: for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/network/tray_sms.cc
diff --git a/ash/common/system/chromeos/network/tray_sms.cc b/ash/common/system/chromeos/network/tray_sms.cc
index 008788169557d9c80998f3fe173a0461af8647eb..5597c7503c8724125ab4d42197ca0f75ee85b093 100644
--- a/ash/common/system/chromeos/network/tray_sms.cc
+++ b/ash/common/system/chromeos/network/tray_sms.cc
@@ -14,7 +14,6 @@
#include "ash/common/system/tray/tray_item_more.h"
#include "ash/common/system/tray/tray_item_view.h"
#include "ash/common/system/tray/tray_notification_view.h"
-#include "ash/common/system/tray/view_click_listener.h"
#include "ash/common/wm_shell.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -190,8 +189,7 @@ class TraySms::SmsMessageView : public views::View,
DISALLOW_COPY_AND_ASSIGN(SmsMessageView);
};
-class TraySms::SmsDetailedView : public TrayDetailsView,
- public ViewClickListener {
+class TraySms::SmsDetailedView : public TrayDetailsView {
public:
explicit SmsDetailedView(TraySms* owner) : TrayDetailsView(owner) {
Init();
@@ -202,7 +200,7 @@ class TraySms::SmsDetailedView : public TrayDetailsView,
void Init() {
CreateScrollableList();
- CreateSpecialRow(IDS_ASH_STATUS_TRAY_SMS, this);
+ CreateTitleRow(IDS_ASH_STATUS_TRAY_SMS);
}
void Update() {
@@ -243,12 +241,6 @@ class TraySms::SmsDetailedView : public TrayDetailsView,
scroller()->Layout();
}
- // Overridden from ViewClickListener.
- void OnViewClicked(views::View* sender) override {
- if (sender == footer()->content())
- TransitionToDefaultView();
- }
-
DISALLOW_COPY_AND_ASSIGN(SmsDetailedView);
};

Powered by Google App Engine
This is Rietveld 408576698