DevTools: patch browser's Chrome version into Chrome user agents for emulation

third_party/WebKit/Source/devtools/BUILD.gn

Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index 8e60e0495ce678e16327a961f0e2ff8ef41c14e9..51406d6591654a53d157247b36db2c8361c751dc 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -4,6 +4,7 @@
 
 import("//build/config/features.gni")
 import("//third_party/WebKit/Source/core/core.gni")
+import("//chrome/version.gni")

[dgozman, 2016/09/07 22:06:28]

This looks like a layering violation. Ain't any presubmit complaining?

[luoe, 2016/09/07 22:46:32]

Ninja and presubmit are fine with it, no complaints.

//chrome/version and //third_party/WebKit/Source/core/core.gni both depend on
//build/config/chrome_build.gni.  What's the right way to do this?

 
 devtools_embedder_scripts = [
   "front_end/devtools.js",
@@ -860,6 +861,9 @@ generated_scripts = [
   "$resources_out_dir/SupportedCSSProperties.js",
 ]
 
+generated_version_info_script =
+    [ "$resources_out_dir/CurrentBrowserVersion.js" ]
+
 generated_entry_files = [
   "$resources_out_dir/inspector.html",
   "$resources_out_dir/inspector.js",
@@ -918,6 +922,7 @@ group("devtools_frontend_resources") {
     ":copy_inspector_images",
     ":devtools_extension_api",
     ":frontend_protocol_sources",
+    ":generate_version_info",
     ":supported_css_properties",
   ]
   if (debug_devtools) {
@@ -1031,11 +1036,18 @@ action("frontend_protocol_sources") {
          ]
 }
 
+process_version("generate_version_info") {
+  template_file = "scripts/CurrentBrowserVersion.js"
+  output = "$resources_out_dir/CurrentBrowserVersion.js"
+  process_only = true
+}
+
 action("build_release_devtools") {
   script = "scripts/build_applications.py"
 
   deps = [
     ":frontend_protocol_sources",
+    ":generate_version_info",
     ":supported_css_properties",
   ]
 
@@ -1045,7 +1057,9 @@ action("build_release_devtools") {
     "scripts/rjsmin.py",
   ]
 
-  inputs = helper_scripts + all_devtools_files + generated_scripts + [
+  inputs = helper_scripts + all_devtools_files + generated_scripts +
+           generated_version_info_script +
+           [
              "front_end/inspector.html",
              "front_end/toolbox.html",
            ]
@@ -1115,6 +1129,7 @@ if (debug_devtools) {
       ":copy_generated_scripts",
       ":copy_inspector_images_debug",
       ":copy_runtime_core",
+      ":generate_version_info_debug",
     ]
   }
 
@@ -1149,6 +1164,7 @@ if (debug_devtools) {
       "$resources_out_debug_dir/{{source_file_part}}",
     ]
   }
+
   copy("copy_inspector_images_debug") {
     sources = devtools_image_files
     outputs = [
@@ -1162,4 +1178,10 @@ if (debug_devtools) {
       "$resources_out_debug_dir/emulated_devices/{{source_file_part}}",
     ]
   }
+
+  process_version("generate_version_info_debug") {
+    template_file = "scripts/CurrentBrowserVersion.js"
+    output = "$resources_out_debug_dir/CurrentBrowserVersion.js"
+    process_only = true
+  }
 }