buildbot/master/skia_master_scripts/utils.py - Issue 23001003: Remove base-* directories from gm expected/actual paths; just use platform names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: buildbot/master/skia_master_scripts/utils.py

Issue 23001003: Remove base-* directories from gm expected/actual paths; just use platform names (Closed) Base URL: http://skia.googlecode.com/svn/

Patch Set: buildbot_master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« buildbot/master/skia_master_scripts/skia_build_step.py ('K') | « buildbot/master/skia_master_scripts/skia_build_step.py ('k') | buildbot/tools/tests/factory_configuration/expected/Build-Mac10.6-GCC-x86-Debug » ('j') | buildbot/tools/tests/factory_configuration/expected/Build-Mac10.6-GCC-x86-Debug » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: buildbot/master/skia_master_scripts/utils.py

===================================================================

--- buildbot/master/skia_master_scripts/utils.py (revision 10693)

+++ buildbot/master/skia_master_scripts/utils.py (working copy)

@@ -453,12 +453,10 @@

def _MakeBuilder(helper, role, os, model, gpu, configuration, arch,

- gm_image_subdir, factory_type, extra_config=None,

+ factory_type, extra_config=None,

perf_output_basedir=None, extra_branches=None, is_trybot=False,

**kwargs):

- """ Creates a builder and scheduler.

- TODO(epoger): gm_image_subdir is no longer used, should be removed."""

+ """ Creates a builder and scheduler."""

B = helper.Builder

F = helper.Factory

@@ -489,7 +487,6 @@

builder_name=builder_name,

other_subdirs=subdirs_to_checkout,

configuration=configuration,

- gm_image_subdir=gm_image_subdir,

do_patch_step=is_trybot,

perf_output_basedir=perf_output_basedir,

**kwargs