Chromium Code Reviews| Index: buildbot/master/skia_master_scripts/skia_build_step.py |
| =================================================================== |
| --- buildbot/master/skia_master_scripts/skia_build_step.py (revision 10693) |
| +++ buildbot/master/skia_master_scripts/skia_build_step.py (working copy) |
| @@ -91,29 +91,6 @@ |
| return False |
| -def _CheckRebaselineChanges(changes, gm_image_subdir): |
|
epoger
2013/08/13 18:16:53
As far as I can tell, this function isn't called a
|
| - """ Determine whether a set of changes consists of only files in 'gm-expected' |
| - and whether any of those files are in the given gm_image_subdir. Returns a |
| - tuple consisting of two booleans: whether or not the commit consists of only |
| - new baseline images, and whether or not baselines changed for the given |
| - platform. |
| - |
| - changes: a list of the changelists which are part of this build. |
| - gm_image_subdir: the subdirectory inside gm-expected which corresponds to this |
| - build slave's platform. |
| - """ |
| - commit_is_only_baselines = True |
| - platform_changed = False |
| - for change in changes: |
| - for changed_file in change.asDict()['files']: |
| - for subdir in utils.SKIA_PRIMARY_SUBDIRS: |
| - if subdir != 'gm-expected' and subdir in changed_file['name']: |
| - commit_is_only_baselines = False |
| - if gm_image_subdir in changed_file: |
| - platform_changed = True |
| - return commit_is_only_baselines, platform_changed |
| - |
| - |
| def ShouldDoStep(step): |
| """ At build time, use build properties to determine whether or not a step |
| should be run or skipped. |