third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

index 1a979dc9390a75e0d1de75027d410a2292c02b6d..5b313ec0d73e13a5016c4281dafc8a09cd0617bf 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -77,8 +77,8 @@ public:

void dispatchFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest&) override;

void dispatchForeignFetchEvent(int responseID, int eventFinishID, const WebServiceWorkerRequest&) override;

void dispatchInstallEvent(int) override;

- void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&, int actionIndex) override;

- void dispatchNotificationCloseEvent(int, int64_t notificationID, const WebNotificationData&) override;

+ void dispatchNotificationClickEvent(int, const WebString& notificationID, const WebNotificationData&, int actionIndex) override;

+ void dispatchNotificationCloseEvent(int, const WebString& notificationID, const WebNotificationData&) override;

void dispatchPushEvent(int, const WebString& data) override;

void dispatchSyncEvent(int, const WebString& tag, LastChanceOption) override;

bool hasFetchEventHandler() override;