third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp - Issue 2300093002: Make //content responsible for generating notification Ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 2300093002: Make //content responsible for generating notification Ids (Closed)

Patch Set: comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

index 179e5103f5e1dee7bdc9a4e6db88734e5a617ad3..3294316c4fa8afd16f62e4b3c3b23181e5fe867f 100644

--- a/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

+++ b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

@@ -38,7 +38,7 @@ public:

{

HeapVector<Member<Notification>> notifications;

for (const WebPersistentNotificationInfo& notificationInfo : notificationInfos)

- notifications.append(Notification::create(resolver->getExecutionContext(), notificationInfo.persistentId, notificationInfo.data, true /* showing */));

+ notifications.append(Notification::create(resolver->getExecutionContext(), notificationInfo.notificationId, notificationInfo.data, true /* showing */));

return notifications;

}