Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2299953002: [mb] Copy MB from Chromium repo (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
kjellander_chromium, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Copy MB from Chromium repo This prepares deletion of MB on the Chromium side. This runs validation of the v8 configs as presubmit and removes some obsolete code that required chromium. BUG=chromium:616035 Committed: https://crrev.com/9c9d1e18c7dc71132d3629c6dfe7dc2fb2922b23 Cr-Commit-Position: refs/heads/master@{#39082}

Patch Set 1 #

Patch Set 2 : [mb] Copy MB from Chromium repo #

Patch Set 3 : Pin to V8's config and delete obsolete validation code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2879 lines, -3 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A tools/mb/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A tools/mb/PRESUBMIT.py View 1 1 chunk +41 lines, -0 lines 0 comments Download
A tools/mb/README.md View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/mb/docs/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/mb/docs/design_spec.md View 1 chunk +426 lines, -0 lines 0 comments Download
A tools/mb/docs/user_guide.md View 1 chunk +297 lines, -0 lines 0 comments Download
A tools/mb/mb View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/mb/mb.bat View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/mb/mb.py View 1 2 1 chunk +1500 lines, -0 lines 0 comments Download
A tools/mb/mb_unittest.py View 1 2 1 chunk +572 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Michael Achenbach
PTAL. Copying MB as suggested in email-tread. This will also make us able to fine-tune ...
4 years, 3 months ago (2016-09-01 11:50:00 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-01 12:06:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299953002/40001
4 years, 3 months ago (2016-09-01 12:18:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 12:20:04 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9c9d1e18c7dc71132d3629c6dfe7dc2fb2922b23 Cr-Commit-Position: refs/heads/master@{#39082}
4 years, 3 months ago (2016-09-01 12:20:28 UTC) #19
Dirk Pranke
4 years, 3 months ago (2016-09-01 18:01:50 UTC) #20
Message was sent while issue was closed.
lgtm. I was gonna leave the chromium version alone, but this is probably
preferable :).

Powered by Google App Engine
This is Rietveld 408576698