Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tools/mb/PRESUBMIT.py

Issue 2299953002: [mb] Copy MB from Chromium repo (Closed)
Patch Set: Pin to V8's config and delete obsolete validation code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/mb/OWNERS ('k') | tools/mb/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/PRESUBMIT.py
diff --git a/tools/mb/PRESUBMIT.py b/tools/mb/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..6f5307c63eb3c057f1e3c5b8534dc298b816fca7
--- /dev/null
+++ b/tools/mb/PRESUBMIT.py
@@ -0,0 +1,41 @@
+# Copyright 2016 the V8 project authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+
+def _CommonChecks(input_api, output_api):
+ results = []
+
+ # Run Pylint over the files in the directory.
+ pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api)
+ results.extend(input_api.RunTests(pylint_checks))
+
+ # Run the MB unittests.
+ results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
+ input_api, output_api, '.', [ r'^.+_unittest\.py$']))
+
+ # Validate the format of the mb_config.pyl file.
+ cmd = [input_api.python_executable, 'mb.py', 'validate']
+ kwargs = {'cwd': input_api.PresubmitLocalPath()}
+ results.extend(input_api.RunTests([
+ input_api.Command(name='mb_validate',
+ cmd=cmd, kwargs=kwargs,
+ message=output_api.PresubmitError)]))
+
+ results.extend(
+ input_api.canned_checks.CheckLongLines(
+ input_api,
+ output_api,
+ maxlen=80,
+ source_file_filter=lambda x: 'mb_config.pyl' in x.LocalPath()))
+
+ return results
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ return _CommonChecks(input_api, output_api)
« no previous file with comments | « tools/mb/OWNERS ('k') | tools/mb/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698