Issue 22999026: Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu.

Issue 22999026: Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu. (Closed)

Created:
7 years, 4 months ago by whywhat

Modified:
7 years, 3 months ago

Reviewers:
Lei Zhang, joth

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu. Adds PrintingContext implementation stub for Android. BUG=147070 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218339

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+288 lines, -40 lines)			Patch
build/common.gypi	View	2 chunks	+9 lines, -1 line	0 comments	Download
chrome/android/testshell/testshell_stubs.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
chrome/browser/android/tab_android_test_stubs.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
chrome/browser/printing/print_view_manager_base.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
chrome/browser/printing/print_view_manager_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/printing/print_view_manager_basic.h	View	3 chunks	+29 lines, -1 line	0 comments	Download
chrome/browser/printing/print_view_manager_basic.cc	View	2 chunks	+31 lines, -1 line	0 comments	Download
chrome/browser/printing/printing_message_filter.h	View	1 chunk	+12 lines, -2 lines	0 comments	Download
chrome/browser/printing/printing_message_filter.cc	View	7 chunks	+64 lines, -3 lines	0 comments	Download
chrome/chrome_renderer.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
chrome/common/print_messages.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
chrome/renderer/chrome_mock_render_thread.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
chrome/renderer/chrome_mock_render_thread.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
chrome/renderer/printing/print_web_view_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/renderer/printing/print_web_view_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/renderer/printing/print_web_view_helper_android.cc	View	1 chunk	+7 lines, -0 lines	1 comment	Download
chrome/renderer/printing/print_web_view_helper_linux.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
printing/image_android.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
printing/image_linux.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
printing/metafile.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
printing/pdf_metafile_skia.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
printing/pdf_metafile_skia.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
printing/printed_document.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
printing/printing.gyp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
printing/printing_context_android.h	View	1 chunk	+68 lines, -0 lines	0 comments	Download
skia/skia_chrome.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
skia/skia_library.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

Committed patchset #1 manually as r218339 (presubmit successful).

7 years, 4 months ago (2013-08-19 22:26:31 UTC) #1

Lei Zhang

The raw patches are identical, so lgtm based on lgtms from the reviewed CL.

7 years, 4 months ago (2013-08-19 22:31:22 UTC) #2

joth

7 years, 3 months ago (2013-08-29 21:02:53 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/22999026/diff/1/chrome/renderer/printing/prin...
File chrome/renderer/printing/print_web_view_helper_android.cc (right):

https://codereview.chromium.org/22999026/diff/1/chrome/renderer/printing/prin...
chrome/renderer/printing/print_web_view_helper_android.cc:7: #include
"chrome/renderer/printing/print_web_view_helper_linux.cc"
FYI rather than use #include trick, the (loose) consensus in this thread was to
add a special case to target_conditions in the android section of the gyp.

https://groups.google.com/a/chromium.org/d/topic/chromium-dev/cU9Bppx1ALI/dis...

net.gyp has some examples.

Expand Messages | Collapse Messages