chrome/renderer/printing/print_web_view_helper_android.cc - Issue 22999026: Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/printing/print_web_view_helper_android.cc

Issue 22999026: Submitting https://codereview.chromium.org/23116003/ for Cihat Imamoglu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // All the necessary logic already lives in print_web_view_helper_linux.cc.

	6 // We need a separate file for Android due to build/filename_rules.gypi rules.

	7 #include "chrome/renderer/printing/print_web_view_helper_linux.cc"
	joth 2013/08/29 21:02:53 FYI rather than use #include trick, the (loose) co FYI rather than use #include trick, the (loose) consensus in this thread was to add a special case to target_conditions in the android section of the gyp. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/cU9Bppx1ALI/dis... net.gyp has some examples.
OLD	NEW

« no previous file with comments | « chrome/renderer/printing/print_web_view_helper.cc ('k') | chrome/renderer/printing/print_web_view_helper_linux.cc » ('j') | no next file with comments »