[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org

Committed: https://crrev.com/ebf057e94cd8ca83476f8780ae7419f7ba8746cf
Cr-Commit-Position: refs/heads/master@{#415866}

[eae, 2016-08-31 22:52:12]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-31 23:01:35]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 23:02:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-31 23:22:16]

Description was changed from

==========
[LayoutNG] Merge NGDerivedConstraintSpace into derived NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org
==========

to

==========
[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org
==========

[cbiesinger, 2016-08-31 23:43:57]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2016-08-31 23:43:58]

lgtm

https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):

https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:29:
NGConstraintSpace(NGWritingMode, NGLogicalSize);
This should maybe have a comment that the size will be used for both Size() and
ContainerSize()

https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:52: //
NGConstraintSpace or a NGPhysicalConstraintSpace.
Hmm, not convinced how a root constraint space would be useful, but we can cross
that bridge when we get there.

[commit-bot: I haz the power, 2016-09-01 00:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:06:26]

Dry run: Exceeded global retry quota

[ikilpatrick, 2016-09-01 00:20:54]

lgtm

[eae, 2016-09-01 02:38:31]

On 2016/08/31 23:43:58, cbiesinger wrote:
> lgtm
> 
>
https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h (right):
> 
>
https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:29:
> NGConstraintSpace(NGWritingMode, NGLogicalSize);
> This should maybe have a comment that the size will be used for both Size()
and
> ContainerSize()
> 
>
https://codereview.chromium.org/2299823002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h:52: //
> NGConstraintSpace or a NGPhysicalConstraintSpace.
> Hmm, not convinced how a root constraint space would be useful, but we can
cross
> that bridge when we get there.

I was thinking for resolving vw/vh and percentage lengths but yeah, we can
revisit that later.

[eae, 2016-09-01 02:38:37]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-09-01 02:38:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 03:03:30]

Description was changed from

==========
[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org
==========

to

==========
[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org
==========

[commit-bot: I haz the power, 2016-09-01 03:03:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 03:05:45]

Description was changed from

==========
[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org
==========

to

==========
[LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace

BUG=635619
R=ikilpatrick@chromium.org

Committed: https://crrev.com/ebf057e94cd8ca83476f8780ae7419f7ba8746cf
Cr-Commit-Position: refs/heads/master@{#415866}
==========

[commit-bot: I haz the power, 2016-09-01 03:05:46]

Patchset 2 (id:??) landed as
https://crrev.com/ebf057e94cd8ca83476f8780ae7419f7ba8746cf
Cr-Commit-Position: refs/heads/master@{#415866}