Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h

Issue 2299823002: [LayoutNG] Merge NGDerivedConstraintSpace into NGConstraintSpace (Closed)
Patch Set: Fix copy constructors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h
deleted file mode 100644
index 9b46495359a7254676cf37ba39a9306d73e74d46..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/core/layout/ng/ng_derived_constraint_space.h
+++ /dev/null
@@ -1,57 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef NGDerivedConstraintSpace_h
-#define NGDerivedConstraintSpace_h
-
-#include "core/CoreExport.h"
-#include "core/layout/ng/ng_constraint_space.h"
-#include "core/layout/ng/ng_units.h"
-#include "platform/LayoutUnit.h"
-#include "wtf/DoublyLinkedList.h"
-
-namespace blink {
-
-class CORE_EXPORT NGDerivedConstraintSpace final : public NGConstraintSpace {
- public:
- // Constructs a NGConstraintSpace from legacy layout object.
- static NGDerivedConstraintSpace* CreateFromLayoutObject(const LayoutBox&);
-
- NGDerivedConstraintSpace(NGWritingMode,
- NGLogicalSize container_size,
- bool inline_triggers,
- bool block_triggers,
- bool fixed_inline,
- bool fixed_block,
- NGFragmentationType);
-
- NGLogicalOffset Offset() const { return offset_; }
- NGLogicalSize Size() const override { return size_; }
- NGDirection Direction() const { return direction_; }
-
- // TODO(layout-ng): All exclusion operations on a NGDerivedConstraintSpace
- // should be performed on it's parent if it exists. This is so that if a float
- // is added by a child an arbitary sibling can avoid/clear that float.
- // Alternatively the list of exclusions could be shared between constraint
- // spaces.
-
- DEFINE_INLINE_VIRTUAL_TRACE() {
- visitor->trace(parent_);
- NGConstraintSpace::trace(visitor);
- }
-
- private:
- Member<NGConstraintSpace> parent_;
- NGLogicalOffset offset_;
-
- // TODO(layout-ng) move to NGPhysicalConstraintSpace?
- NGLogicalSize size_;
-
- // TODO(layout-ng) move to NGConstraintSpace?
- NGDirection direction_;
-};
-
-} // namespace blink
-
-#endif // NGDerivedConstraintSpace_h

Powered by Google App Engine
This is Rietveld 408576698