Issue 229973003: Move '#include <string.h>' into '#if defined(ADDRESS_SANITIZER)' block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 229973003: Move '#include <string.h>' into '#if defined(ADDRESS_SANITIZER)' block. (Closed)

Created:
6 years, 8 months ago by Sungmann Cho

Modified:
6 years, 8 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Move '#include <string.h>' into '#if defined(ADDRESS_SANITIZER)' block. The string.h is required only when using the address sanitizer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262967

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/chrome_exe_main_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/229973003/1

6 years, 8 months ago (2014-04-10 05:52:01 UTC) #4

Message was sent while issue was closed.

Change committed as 262967