chrome/app/chrome_exe_main_mac.cc - Issue 229973003: Move '#include <string.h>' into '#if defined(ADDRESS_SANITIZER)' block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_exe_main_mac.cc

Issue 229973003: Move '#include <string.h>' into '#if defined(ADDRESS_SANITIZER)' block. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_exe_main_mac.cc

diff --git a/chrome/app/chrome_exe_main_mac.cc b/chrome/app/chrome_exe_main_mac.cc

index 84c22e084e060f74e23136154f6f662677ee4947..a0f1ac589e17e1ce165a991d01b5490140755f9e 100644

--- a/chrome/app/chrome_exe_main_mac.cc

+++ b/chrome/app/chrome_exe_main_mac.cc

@@ -7,9 +7,9 @@

#if defined(ADDRESS_SANITIZER)

#include <crt_externs.h> // for _NSGetArgc, _NSGetArgv

+#include <string.h>

#endif // ADDRESS_SANITIZER

#include <stdlib.h>

-#include <string.h>

#if defined(ADDRESS_SANITIZER)

// NaCl requires its own SEGV handler, so we need to add handle_segv=0 to

« no previous file with comments | « no previous file | no next file » | no next file with comments »