Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2299663002:
In VulkanWindowContext add check to see if ganesh changed the layout of the image. (Closed)
DescriptionIn VulkanWindowContext add check to see if ganesh changed the layout of the image.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/580fa596c9648c3dafb7980d3304c82d4502c719
Patch Set 1 #
Total comments: 2
Patch Set 2 : spelling #
Messages
Total messages: 27 (18 generated)
egdaniel@google.com changed reviewers: + jvanverth@google.com
lgtm https://codereview.chromium.org/2299663002/diff/1/src/gpu/vk/GrVkRenderTarget... File src/gpu/vk/GrVkRenderTarget.cpp (right): https://codereview.chromium.org/2299663002/diff/1/src/gpu/vk/GrVkRenderTarget... src/gpu/vk/GrVkRenderTarget.cpp:356: // If the render target is multisampled, we current return the ImageInfo for the resolved image. Nit: currently
https://codereview.chromium.org/2299663002/diff/1/src/gpu/vk/GrVkRenderTarget... File src/gpu/vk/GrVkRenderTarget.cpp (right): https://codereview.chromium.org/2299663002/diff/1/src/gpu/vk/GrVkRenderTarget... src/gpu/vk/GrVkRenderTarget.cpp:356: // If the render target is multisampled, we current return the ImageInfo for the resolved image. On 2016/08/31 17:09:42, jvanverth1 wrote: > Nit: currently Done.
The CQ bit was checked by egdaniel@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com Link to the patchset: https://codereview.chromium.org/2299663002/#ps20001 (title: "spelling")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by egdaniel@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was unchecked by egdaniel@google.com
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== In VulkanWindowContext add check to see if ganesh changed the layout of the image. BUG=skia: ========== to ========== In VulkanWindowContext add check to see if ganesh changed the layout of the image. BUG=skia: Committed: https://skia.googlesource.com/skia/+/580fa596c9648c3dafb7980d3304c82d4502c719 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/580fa596c9648c3dafb7980d3304c82d4502c719 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
