Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 22996005: Revert 217722 "[Sheriff] Disable SafeBrowsingBlockingPageTest.Ma..." (Closed)

Created:
7 years, 4 months ago by tasak
Modified:
7 years, 4 months ago
Reviewers:
rpetterson
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217722 "[Sheriff] Disable SafeBrowsingBlockingPageTest.Ma..." Because the patch broke compile on Win Aura builder. c.f. FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma\gomacc.exe "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\chrome\browser\safe_browsing\browser_tests.safe_browsing_blocking_page_test.obj.rsp /c ..\..\chrome\browser\safe_browsing\safe_browsing_blocking_page_test.cc /Foobj\chrome\browser\safe_browsing\browser_tests.safe_browsing_blocking_page_test.obj /Fdobj\chrome\browser_tests.pdb c:\b\build\slave\win_aura_builder\build\src\chrome\browser\safe_browsing\safe_browsing_blocking_page_test.cc(717) : error C2504: 'DISABLED_SafeBrowsingBlockingPageTest' : base class undefined ... > [Sheriff] Disable SafeBrowsingBlockingPageTest.MalwareIframeReportDetails on Win Aura because it is flaky. > > BUG=273302 > TBR=mattm@chromium.org > > Review URL: https://codereview.chromium.org/23227003 TBR=rlp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M trunk/src/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tasak
7 years, 4 months ago (2013-08-15 02:14:09 UTC) #1
tasak
Committed patchset #1 manually as r217732.
7 years, 4 months ago (2013-08-15 02:14:21 UTC) #2
rpetterson
7 years, 4 months ago (2013-08-15 02:48:35 UTC) #3
Thank you for taking care of this!

LGTM
On Aug 14, 2013 7:14 PM, <tasak@google.com> wrote:

> Committed patchset #1 manually as r217732.
>
>
https://codereview.chromium.**org/22996005/<https://codereview.chromium.org/2...
>

Powered by Google App Engine
This is Rietveld 408576698