Issue 23227003: [Sheriff] Disable SafeBrowsingBlockingPageTest.MalwareIframeReportDetails on Win Aura because it is…

Issue 23227003: [Sheriff] Disable SafeBrowsingBlockingPageTest.MalwareIframeReportDetails on Win Aura because it is… (Closed)

Created:
7 years, 4 months ago by rpetterson

Modified:
7 years, 4 months ago

Reviewers:
ericu, tapted, mattm, rlp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sheriff] Disable SafeBrowsingBlockingPageTest.MalwareIframeReportDetails on Win Aura because it is flaky. BUG=273302 TBR=mattm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217722

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc	View		1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tapted

https://codereview.chromium.org/23227003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc File chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc (right): https://codereview.chromium.org/23227003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc#newcode717 chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc:717: MalwareIframeReportDetails) { I think the MAYBE_ should on this ...

7 years, 4 months ago (2013-08-15 02:14:44 UTC) #4

ericu

7 years, 4 months ago (2013-08-15 02:20:20 UTC) #5

rpetterson

Doh is right . . . I'll fix that as soon as I get home ...

7 years, 4 months ago (2013-08-15 02:44:21 UTC) #6

rlp

7 years, 4 months ago (2013-08-15 02:47:57 UTC) #7

Looks like tasak@ got it!
On Aug 14, 2013 7:44 PM, "Rachel Weinstein Petterson" <rlp@chromium.org>
wrote:

> Doh is right . . . I'll fix that as soon as I get home unless someone else
> gets to it sooner. I'm surprised it even compiled!
> On Aug 14, 2013 7:20 PM, <ericu@chromium.org> wrote:
>
>>
>> https://codereview.chromium.**org/23227003/diff/1/chrome/**
>>
browser/safe_browsing/safe_**browsing_blocking_page_test.cc<https://codereview.chromium.org/23227003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc>
>> File chrome/browser/safe_browsing/**safe_browsing_blocking_page_**test.cc
>> (right):
>>
>> https://codereview.chromium.**org/23227003/diff/1/chrome/**
>>
browser/safe_browsing/safe_**browsing_blocking_page_test.**cc#newcode717<https://codereview.chromium.org/23227003/diff/1/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc#newcode717>
>> chrome/browser/safe_browsing/**safe_browsing_blocking_page_**test.cc:717:
>> MalwareIframeReportDetails) {
>> On 2013/08/15 02:14:45, tapted wrote:
>>
>>> I think the MAYBE_ should on this line ;)
>>>
>>
>> Doh!
>>
>>
https://codereview.chromium.**org/23227003/<https://codereview.chromium.org/2...
>>
>

Expand Messages | Collapse Messages