Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 229943006: ElementsAccessor::SetLength() maybehandlified. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

ElementsAccessor::SetLength() maybehandlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -34 lines) Patch
M src/accessors.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/elements.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/elements.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 8 months ago (2014-04-09 10:07:43 UTC) #1
Yang
On 2014/04/09 10:07:43, Igor Sheludko wrote: > PTAL lgtm.
6 years, 8 months ago (2014-04-09 12:20:54 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-09 13:16:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698