src/runtime.cc - Issue 229943006: ElementsAccessor::SetLength() maybehandlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 229943006: ElementsAccessor::SetLength() maybehandlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index e46fbba6474552121c7c2bcb105924276515658e..be821e5efface3792a78e23c14cd01e6a41a29ce 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -15027,8 +15027,8 @@ static MaybeObject* ArrayConstructorCommon(Isolate* isolate,

factory->NewJSArrayStorage(array, 0, 0, DONT_INITIALIZE_ARRAY_ELEMENTS);

ElementsKind old_kind = array->GetElementsKind();

- RETURN_IF_EMPTY_HANDLE(isolate,

- ArrayConstructInitializeElements(array, caller_args));

+ RETURN_FAILURE_ON_EXCEPTION(

+ isolate, ArrayConstructInitializeElements(array, caller_args));

if (!site.is_null() &&

(old_kind != array->GetElementsKind() ||

!can_use_type_feedback)) {

« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »