Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2299273002: Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/210… (Closed)

Created:
4 years, 3 months ago by Tom (Use chromium acct)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ ) Reason for revert: Breaks icons on deb packages Original issue's description: > Support relocatable RPM packages > > BUG=31519 > > Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99 > Cr-Commit-Position: refs/heads/master@{#402666} TBR=thestig@chromium.org BUG=642953 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2299093002 Cr-Commit-Position: refs/heads/master@{#415840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -58 lines) Patch
M chrome/installer/linux/common/apt.include View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/chromium-browser/chromium-browser.info View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/installer/linux/common/google-chrome/google-chrome.info View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/linux/common/postinst.include View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/linux/common/prerm.include View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/common/rpm.include View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/symlinks.include View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/installer/linux/common/variables.include View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/installer/linux/debian/postinst View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/installer/linux/debian/postrm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/linux/debian/prerm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/rpm/chrome.spec.template View 5 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299273002/1
4 years, 3 months ago (2016-09-01 19:32:43 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-01 19:32:45 UTC) #4
Michael Moss
lgtm
4 years, 3 months ago (2016-09-01 19:36:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299273002/1
4 years, 3 months ago (2016-09-01 19:37:42 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-01 19:37:43 UTC) #10
dimu
On 2016/09/01 19:37:43, commit-bot: I haz the power wrote: > CLs for remote refs other ...
4 years, 3 months ago (2016-09-01 20:41:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299273002/1
4 years, 3 months ago (2016-09-01 21:03:25 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:07:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698