Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2299093002: Revert of Support relocatable RPM packages (Closed)

Created:
4 years, 3 months ago by Tom (Use chromium acct)
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support relocatable RPM packages (patchset #1 id:1 of https://codereview.chromium.org/2107893004/ ) Reason for revert: Breaks icons on deb packages Original issue's description: > Support relocatable RPM packages > > BUG=31519 > > Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99 > Cr-Commit-Position: refs/heads/master@{#402666} TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642953 Committed: https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936 Cr-Commit-Position: refs/heads/master@{#415840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -58 lines) Patch
M chrome/installer/linux/common/apt.include View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/chromium-browser/chromium-browser.info View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/installer/linux/common/google-chrome/google-chrome.info View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/linux/common/postinst.include View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/linux/common/prerm.include View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/common/rpm.include View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/linux/common/symlinks.include View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/installer/linux/common/variables.include View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/installer/linux/debian/postinst View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/installer/linux/debian/postrm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/linux/debian/prerm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/linux/rpm/chrome.spec.template View 5 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Tom (Use chromium acct)
Created Revert of Support relocatable RPM packages
4 years, 3 months ago (2016-09-01 00:22:29 UTC) #2
Tom (Use chromium acct)
+ mmoss fyi
4 years, 3 months ago (2016-09-01 00:23:02 UTC) #4
Lei Zhang
1. Can you reference the new bug? 2. Is this a clean revert?
4 years, 3 months ago (2016-09-01 00:23:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299093002/1
4 years, 3 months ago (2016-09-01 00:23:24 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-01 00:23:25 UTC) #8
Lei Zhang
Err, and do we understand why it's breaking? Not yet?
4 years, 3 months ago (2016-09-01 00:23:39 UTC) #9
Tom (Use chromium acct)
On 2016/09/01 00:23:39, Lei Zhang wrote: > Err, and do we understand why it's breaking? ...
4 years, 3 months ago (2016-09-01 00:27:11 UTC) #11
Lei Zhang
lgtm assuming it's a clean revert.
4 years, 3 months ago (2016-09-01 00:29:34 UTC) #12
Tom (Use chromium acct)
The revert appears to have fixed the icons on my Goobuntu install, so going to ...
4 years, 3 months ago (2016-09-01 01:38:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299093002/1
4 years, 3 months ago (2016-09-01 01:38:43 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 01:43:32 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 01:48:19 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6884a31eba1024e7ca1a4d1d2906be06dd20936
Cr-Commit-Position: refs/heads/master@{#415840}

Powered by Google App Engine
This is Rietveld 408576698