Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2299163003: [Merge to 55.0.2846.2] Revert of Fix memory leak in ThreadWatcher. (patchset #3 id:40001 of https:/… (Closed)

Created:
4 years, 3 months ago by gab
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2846
Project:
chromium
Visibility:
Public.

Description

[Merge to 55.0.2846.2] Revert of Fix memory leak in ThreadWatcher. (patchset #3 id:40001 of https://codereview.chromium.org/2295983002/ ) Reason for revert: Current Canary is unusable due to browser process crashes in line 88 (Windows) and 389 (Mac) in thread_watcher.cc, see crbug.com/643109. Original issue's description: > Fix memory leak in ThreadWatcher. > > BUG=none > TEST=unit tests > > Committed: https://crrev.com/5ca77e86703646cb84be35ef827068ac6951be1e > Cr-Commit-Position: refs/heads/master@{#415729} TBR=isherman@chromium.org,rtenneti@chromium.org,wzhong@chromium.org,alokp@chromium.org,jlevasseur@chromium.org NOPRESUBMIT=true NOTRY=true BUG=643109 Review-Url: https://codereview.chromium.org/2299453005 Cr-Commit-Position: refs/heads/master@{#415955} (cherry picked from commit ec1da671f97f53a3fa24505c80593229264941fd) Committed: https://chromium.googlesource.com/chromium/src/+/1917cde9d763b20e310b04da3c8d336b2fafbc5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M chrome/browser/metrics/thread_watcher.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 3 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
gab
TBR for merge to Canary tip.
4 years, 3 months ago (2016-09-01 15:23:03 UTC) #1
gab
4 years, 3 months ago (2016-09-01 15:28:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1917cde9d763b20e310b04da3c8d336b2fafbc5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698