Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 2299453005: Revert of Fix memory leak in ThreadWatcher. (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, gab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix memory leak in ThreadWatcher. (patchset #3 id:40001 of https://codereview.chromium.org/2295983002/ ) Reason for revert: Current Canary is unusable due to browser process crashes in line 88 (Windows) and 389 (Mac) in thread_watcher.cc, see crbug.com/643109. Original issue's description: > Fix memory leak in ThreadWatcher. > > BUG=none > TEST=unit tests > > Committed: https://crrev.com/5ca77e86703646cb84be35ef827068ac6951be1e > Cr-Commit-Position: refs/heads/master@{#415729} TBR=isherman@chromium.org,rtenneti@chromium.org,wzhong@chromium.org,alokp@chromium.org,jlevasseur@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTRY=true BUG=643109 Committed: https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd Cr-Commit-Position: refs/heads/master@{#415955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M chrome/browser/metrics/thread_watcher.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 3 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jakob Kummerow
Created Revert of Fix memory leak in ThreadWatcher.
4 years, 3 months ago (2016-09-01 13:36:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299453005/1
4 years, 3 months ago (2016-09-01 13:37:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299453005/1
4 years, 3 months ago (2016-09-01 15:17:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 15:18:08 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:20:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec1da671f97f53a3fa24505c80593229264941fd
Cr-Commit-Position: refs/heads/master@{#415955}

Powered by Google App Engine
This is Rietveld 408576698