Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: net/quic/chromium/quic_http_stream.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_http_stream.h
diff --git a/net/quic/chromium/quic_http_stream.h b/net/quic/chromium/quic_http_stream.h
index 79bb187b828d5d33d92fe46fef72521e2e1c80af..9e79d91775660befc0e8b03ab8903bed50b6ac45 100644
--- a/net/quic/chromium/quic_http_stream.h
+++ b/net/quic/chromium/quic_http_stream.h
@@ -48,7 +48,6 @@ class NET_EXPORT_PRIVATE QuicHttpStream
int SendRequest(const HttpRequestHeaders& request_headers,
HttpResponseInfo* response,
const CompletionCallback& callback) override;
- UploadProgress GetUploadProgress() const override;
int ReadResponseHeaders(const CompletionCallback& callback) override;
int ReadResponseBody(IOBuffer* buf,
int buf_len,
@@ -132,6 +131,8 @@ class NET_EXPORT_PRIVATE QuicHttpStream
void ResetStream();
bool CancelPromiseIfHasBody();
+ void ResetRequestInfo();
+
State next_state_;
base::WeakPtr<QuicChromiumClientSession> session_;
@@ -144,7 +145,9 @@ class NET_EXPORT_PRIVATE QuicHttpStream
// outlive this object, according to the HttpStream contract.
// The request to send.
+ // Only valid before the response body is read.
const HttpRequestInfo* request_info_;
+
// The request body to send, if any, owned by the caller.
UploadDataStream* request_body_stream_;
// Time the request was issued.

Powered by Google App Engine
This is Rietveld 408576698