Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: net/http/http_transaction.h

Issue 2298823002: Resetting the HttpRequestInfo pointers in HttpNetworkTransaction and streams (Closed)
Patch Set: Rebased, removed upload progress plumbing, feedback. (Rebased till refs/heads/master@{#417381}) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index 76fd12b7d8bb4f1c6fa262683d8573f16b30592a..8f645619c2a2d0a88bff2b5de2b4d07c5625235a 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -52,6 +52,9 @@ class NET_EXPORT_PRIVATE HttpTransaction {
// Starts the HTTP transaction (i.e., sends the HTTP request).
//
+ // The consumer should ensure that request_info points to a valid value till
+ // final response headers are received.
Randy Smith (Not in Mondays) 2016/09/09 17:28:24 nit, suggestion: "; after that point, the HttpTran
shivanisha 2016/09/13 19:58:34 done.
+ //
// Returns OK if the transaction could be started synchronously, which means
// that the request was served from the cache. ERR_IO_PENDING is returned to
// indicate that the CompletionCallback will be notified once response info is
@@ -148,10 +151,6 @@ class NET_EXPORT_PRIVATE HttpTransaction {
// Returns the load state for this transaction.
virtual LoadState GetLoadState() const = 0;
- // Returns the upload progress in bytes. If there is no upload data,
- // zero will be returned. This does not include the request headers.
- virtual UploadProgress GetUploadProgress() const = 0;
-
// SetQuicServerInfo sets a object which reads and writes public information
// about a QUIC server.
virtual void SetQuicServerInfo(QuicServerInfo* quic_server_info) = 0;

Powered by Google App Engine
This is Rietveld 408576698