Move pre-declaring the this variable to Scope::Analyze

Move pre-declaring the this variable to Scope::Analyze

The goal is to not have to look at the outer scope chain during parsing.

BUG=v8:5215
R=verwaest@chromium.org,marja@chromium.org

Committed: https://crrev.com/92679b023c71a9844619e1bf2126f84383b3ef2b
Cr-Commit-Position: refs/heads/master@{#39042}

[marja, 2016-08-31 08:27:19]

Hmm, this CL is changing the behavior, why is that correct / good?

Now we create the dynamic global this only if

scope->scope_type() != SCRIPT_SCOPE

but afaics we used to create it in Parser::DoParseProgram (in the code which
this CL deletes) in that case.

Should we just always create it?

[Toon Verwaest, 2016-08-31 08:56:55]

https://codereview.chromium.org/2298673002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2298673002/diff/1/src/ast/scopes.cc#newcode417
src/ast/scopes.cc:417:
scope->outer_scope()->GetReceiverScope()->is_script_scope()) {
Shouldn't this just be scope->GetReceiverScope()?

[jochen (gone - plz use gerrit), 2016-08-31 09:18:32]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 09:18:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-08-31 09:18:46]

updated, ptal

[commit-bot: I haz the power, 2016-08-31 09:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 09:43:26]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-31 10:10:08]

lgtm

[jochen (gone - plz use gerrit), 2016-08-31 10:10:41]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-08-31 10:10:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 10:12:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 10:13:01]

Description was changed from

==========
Move pre-declaring the this variable to Scope::Analyze

The goal is to not have to look at the outer scope chain during parsing.

BUG=v8:5215
R=verwaest@chromium.org,marja@chromium.org
==========

to

==========
Move pre-declaring the this variable to Scope::Analyze

The goal is to not have to look at the outer scope chain during parsing.

BUG=v8:5215
R=verwaest@chromium.org,marja@chromium.org

Committed: https://crrev.com/92679b023c71a9844619e1bf2126f84383b3ef2b
Cr-Commit-Position: refs/heads/master@{#39042}
==========

[commit-bot: I haz the power, 2016-08-31 10:13:02]

Patchset 2 (id:??) landed as
https://crrev.com/92679b023c71a9844619e1bf2126f84383b3ef2b
Cr-Commit-Position: refs/heads/master@{#39042}