Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/parsing/parser.cc

Issue 2298673002: Move pre-declaring the this variable to Scope::Analyze (Closed)
Patch Set: updates Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index e82ee9e491ea40621f4ea6795f4ac72426f84895..d450a2aa353b9694b18fd3c5da7bf58f4ea0176e 100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -671,12 +671,6 @@ FunctionLiteral* Parser::DoParseProgram(ParseInfo* info) {
{
Scope* outer = original_scope_;
DCHECK_NOT_NULL(outer);
- // If there's a chance that there's a reference to global 'this', predeclare
- // it as a dynamic global on the script scope.
- if (outer->GetReceiverScope()->is_script_scope()) {
- info->script_scope()->DeclareDynamicGlobal(
- ast_value_factory()->this_string(), Variable::THIS);
- }
if (info->is_eval()) {
if (!outer->is_script_scope() || is_strict(info->language_mode())) {
parsing_mode = PARSE_EAGERLY;
@@ -841,12 +835,6 @@ FunctionLiteral* Parser::DoParseLazy(ParseInfo* info,
// Parse the function literal.
Scope* outer = original_scope_;
DCHECK(outer);
- // If there's a chance that there's a reference to global 'this', predeclare
- // it as a dynamic global on the script scope.
- if (info->is_arrow() && outer->GetReceiverScope()->is_script_scope()) {
- info->script_scope()->DeclareDynamicGlobal(
- ast_value_factory()->this_string(), Variable::THIS);
- }
FunctionState function_state(&function_state_, &scope_state_, outer,
info->function_kind());
DCHECK(is_sloppy(outer->language_mode()) ||
« no previous file with comments | « src/ast/scopes.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698