third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp - Issue 2298613004: [css-align] Check runtime flags for align-items 'auto' value resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 2298613004: [css-align] Check runtime flags for align-items 'auto' value resolution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using Default-Alignment initial value instead of a harcode default value. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

index d75c415acd469210e83212302da0c4557b1fb4de..83ada0d1c1ff1e60c94ac40b967c080ed383f6d2 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

@@ -169,7 +169,7 @@ void StyleAdjuster::adjustStyleForAlignment(ComputedStyle& style, const Computed

// The 'auto' keyword computes the computed value of align-items on the parent

// or 'normal' if the box has no parent.

- if (style.alignSelfPosition() == ItemPositionAuto && parentStyle.alignItemsPosition() != ItemPositionNormal)

+ if (style.alignSelfPosition() == ItemPositionAuto && parentStyle.alignItemsPosition() != ComputedStyle::initialDefaultAlignment().position())

style.setAlignSelf(parentStyle.alignItems());

}

« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | no next file » | no next file with comments »