third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2298613004: [css-align] Check runtime flags for align-items 'auto' value resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2298613004: [css-align] Check runtime flags for align-items 'auto' value resolution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using Default-Alignment initial value instead of a harcode default value. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index ef1ab3cf7ccbbe200a8d81e6721fd1ec322a133f..a435498634552f75aa277e1f3e24c91de66b2d6a 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -447,7 +447,7 @@ static CSSValueList* valueForItemPositionWithOverflowAlignment(const StyleSelfAl

if (data.positionType() == LegacyPosition)

result->append(*CSSPrimitiveValue::createIdentifier(CSSValueLegacy));

// To avoid needing to copy the RareNonInheritedData, we repurpose the 'auto' flag to not just mean 'auto' prior to running the StyleAdjuster but also mean 'normal' after running it.

- result->append(*CSSPrimitiveValue::create(data.position() == ItemPositionAuto ? ItemPositionNormal : data.position()));

+ result->append(*CSSPrimitiveValue::create(data.position() == ItemPositionAuto ? ComputedStyle::initialDefaultAlignment().position() : data.position()));

if (data.position() >= ItemPositionCenter && data.overflow() != OverflowAlignmentDefault)

result->append(*CSSPrimitiveValue::create(data.overflow()));

ASSERT(result->length() <= 2);

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp » ('j') | no next file with comments »