Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2298373002: DevTools: remove indirection between CSSWorkspaceBindings and CSS mappings (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove indirection between CSSWorkspaceBindings and CSS mappings This patch: - makes StylesSourceMapping listen to styleSheetAdded/styleSheetRemoved events by itself. SASSSourceMapping doesn't need to - it relies on SourceMapAttached event. - disposes CSSWorkspaceBindings.TargetInfo properly, by disposing CSS mappings. BUG=none R=dgozman Committed: https://crrev.com/b96c9803fbdb2647e89317ca04e62d82339b67ab Cr-Commit-Position: refs/heads/master@{#417193}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -58 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js View 2 chunks +2 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 3 chunks +10 lines, -23 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 4 chunks +21 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
lushnikov
please, take a look
4 years, 3 months ago (2016-08-31 19:41:14 UTC) #1
dgozman
https://codereview.chromium.org/2298373002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js (left): https://codereview.chromium.org/2298373002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js#oldcode116 third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:116: WebInspector.cssWorkspaceBinding.updateLocations(header); Who calls this now?
4 years, 3 months ago (2016-09-01 00:49:25 UTC) #6
lushnikov
https://codereview.chromium.org/2298373002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js (left): https://codereview.chromium.org/2298373002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js#oldcode116 third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:116: WebInspector.cssWorkspaceBinding.updateLocations(header); On 2016/09/01 00:49:25, dgozman wrote: > Who calls ...
4 years, 3 months ago (2016-09-01 01:34:34 UTC) #7
dgozman
lgtm
4 years, 3 months ago (2016-09-01 01:42:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298373002/1
4 years, 3 months ago (2016-09-08 03:40:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 05:40:08 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:41:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b96c9803fbdb2647e89317ca04e62d82339b67ab
Cr-Commit-Position: refs/heads/master@{#417193}

Powered by Google App Engine
This is Rietveld 408576698