Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2300523002: DevTools: cleanup WI.CSSWorkspaceBindings (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: cleanup WI.CSSWorkspaceBindings This patch: - removes WI.CSSWorkspaceBindings.pushSourceMapping. There's no need to push any source mappings - rawLocationToUILocation can always query SASSSourceMapping first and then StylesSourceMapping. - removes WI.CSSWorkspaceBindings.HeaderInfo. The class was inlined into WI.CSSWorkspaceBindings.TargetInfo. BUG=642583 R=dgozman Committed: https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7 Cr-Commit-Position: refs/heads/master@{#417166}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Messages

Total messages: 13 (7 generated)
lushnikov
please, take a look!
4 years, 3 months ago (2016-08-31 02:30:00 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2300523002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js (right): https://codereview.chromium.org/2300523002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js#newcode101 third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js:101: WebInspector.cssWorkspaceBinding.updateLocations(header); Remove.
4 years, 3 months ago (2016-09-02 19:13:01 UTC) #6
lushnikov
https://codereview.chromium.org/2300523002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js (right): https://codereview.chromium.org/2300523002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js#newcode101 third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js:101: WebInspector.cssWorkspaceBinding.updateLocations(header); On 2016/09/02 19:13:01, dgozman wrote: > Remove. Done.
4 years, 3 months ago (2016-09-08 00:20:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300523002/20001
4 years, 3 months ago (2016-09-08 00:21:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 02:18:00 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 02:19:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7
Cr-Commit-Position: refs/heads/master@{#417166}

Powered by Google App Engine
This is Rietveld 408576698