Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2298243003: Remove outdated context parameter. (Closed)

Created:
4 years, 3 months ago by gayane -on leave until 09-2017
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove outdated context parameter. context used to be used by PrivacyPreferencesManager.getInstance (removed in https://codereview.chromium.org/2105183002) method called from FirstRunGlueImpl.acceptTermsOfService (removed in https://codereview.chromium.org/2248243002). Both of these is not true anymore so there is no need passing context around. Committed: https://crrev.com/c3e7c7c18cabb21214a091ee5efc2d8aec58a22c Cr-Commit-Position: refs/heads/master@{#415724}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
gayane -on leave until 09-2017
PTAL
4 years, 3 months ago (2016-08-31 19:25:17 UTC) #9
gone
lgtm
4 years, 3 months ago (2016-08-31 19:28:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298243003/1
4 years, 3 months ago (2016-08-31 19:29:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 19:34:32 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:36:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e7c7c18cabb21214a091ee5efc2d8aec58a22c
Cr-Commit-Position: refs/heads/master@{#415724}

Powered by Google App Engine
This is Rietveld 408576698