Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2298213003: Revert of Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests (Closed)

Created:
4 years, 3 months ago by stanisc
Modified:
4 years, 3 months ago
Reviewers:
ncarter (slow), battre
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests (patchset #1 id:1 of https://codereview.chromium.org/2301493002/ ) Reason for revert: The bug is now fixed so disabling these tests is no longer needed. See https://codereview.chromium.org/2293293002/ Original issue's description: > Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests > > BUG=642482 > TBR=stanisc@chromium.org,nick@chromium.org: > > Committed: https://crrev.com/a01d97dff593c530fe6b204421bdaa39252801e9 > Cr-Commit-Position: refs/heads/master@{#415595} TBR=nick@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642482 Committed: https://crrev.com/c01fc42411021d8ea86a8e19fc90edba153d92b3 Cr-Commit-Position: refs/heads/master@{#415747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
stanisc
Created Revert of Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests
4 years, 3 months ago (2016-08-31 20:48:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298213003/1
4 years, 3 months ago (2016-08-31 20:48:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:49:44 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:53:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c01fc42411021d8ea86a8e19fc90edba153d92b3
Cr-Commit-Position: refs/heads/master@{#415747}

Powered by Google App Engine
This is Rietveld 408576698