Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/browser/task_manager/task_manager_browsertest.cc

Issue 2298213003: Revert of Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager_browsertest.cc
diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc
index 926845ff56adeca6b5796a14a4014fd7eabd867f..69a60f8326a1d62a17a4704d4208dffd9854cb2a 100644
--- a/chrome/browser/task_manager/task_manager_browsertest.cc
+++ b/chrome/browser/task_manager/task_manager_browsertest.cc
@@ -699,9 +699,7 @@
WaitForTaskManagerRows(1, MatchUtility(proxy_resolver_name)));
}
-// TODO(crbug.com/642482): Disabled flaky test.
-IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest,
- DISABLED_DevToolsNewDockedWindow) {
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, DevToolsNewDockedWindow) {
ShowTaskManager(); // Task manager shown BEFORE dev tools window.
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
@@ -712,9 +710,7 @@
DevToolsWindowTesting::CloseDevToolsWindowSync(devtools);
}
-// TODO(crbug.com/642482): Disabled flaky test.
-IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest,
- DISABLED_DevToolsNewUndockedWindow) {
+IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, DevToolsNewUndockedWindow) {
ShowTaskManager(); // Task manager shown BEFORE dev tools window.
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
DevToolsWindow* devtools =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698