Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2298203002: GN: forgot Clang+ccache fix on Android. And sort. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: forgot Clang+ccache fix on Android. And sort. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298203002 No trybots for these yet... NOTRY=true TBR=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/272b311298d78569c88130ceee3096b876fcbf25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M infra/bots/recipe_modules/flavor/gn_android_flavor.py View 1 chunk +5 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-arm64-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 3 months ago (2016-08-31 12:02:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298203002/1
4 years, 3 months ago (2016-08-31 12:02:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/272b311298d78569c88130ceee3096b876fcbf25
4 years, 3 months ago (2016-08-31 12:03:36 UTC) #9
jcgregorio
4 years, 3 months ago (2016-08-31 12:14:47 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698