Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: infra/bots/recipe_modules/flavor/gn_android_flavor.py

Issue 2298203002: GN: forgot Clang+ccache fix on Android. And sort. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/flavor/gn_android_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/gn_android_flavor.py b/infra/bots/recipe_modules/flavor/gn_android_flavor.py
index 8965233e06ef0c9f0f9d8e427978cd91e6b29a67..9f3480a1a7f593012211aa128a835a1d4dad8526 100644
--- a/infra/bots/recipe_modules/flavor/gn_android_flavor.py
+++ b/infra/bots/recipe_modules/flavor/gn_android_flavor.py
@@ -18,19 +18,22 @@ class GNAndroidFlavorUtils(default_flavor.DefaultFlavorUtils):
assert compiler == 'Clang' # At this rate we might not ever support GCC.
compiler_prefix = ''
+ extra_cflags = []
ccache = self.m.run.ccache()
if ccache:
compiler_prefix = ccache
+ extra_cflags.append('-Qunused-arguments')
ndk_asset = 'android_ndk_linux' if os == 'Ubuntu' else 'android_ndk_darwin'
quote = lambda x: '"%s"' % x
- gn_args = ' '.join('%s=%s' % (k,v) for (k,v) in {
+ gn_args = ' '.join('%s=%s' % (k,v) for (k,v) in sorted({
'compiler_prefix': quote(compiler_prefix),
+ 'extra_cflags': quote(' '.join(extra_cflags)),
'is_debug': 'true' if configuration == 'Debug' else 'false',
'ndk': quote(self.m.vars.slave_dir.join(ndk_asset)),
'target_cpu': quote(target_arch),
- }.iteritems())
+ }.iteritems()))
run = lambda title, cmd: self.m.run(self.m.step, title, cmd=cmd,
cwd=self.m.vars.skia_dir, **kwargs)
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-mipsel-Debug-GN_Android.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698