Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2298193002: Fragment blocks with non-visible overflow as normally when printing. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fragment blocks with non-visible overflow as normally when printing. Splitting scrollbars into multiple fragmentainers is only problematic in interactive media. We don't need to impose any such pagination restrictions when printing, since printing is non-interactive, BUG=641983 Committed: https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8 Cr-Commit-Position: refs/heads/master@{#415645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/printing/overflow-auto.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/overflow-auto-expected.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-08-31 12:56:40 UTC) #6
eae
LGTM
4 years, 3 months ago (2016-08-31 16:08:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298193002/1
4 years, 3 months ago (2016-08-31 16:08:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 16:14:13 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8 Cr-Commit-Position: refs/heads/master@{#415645}
4 years, 3 months ago (2016-08-31 16:17:32 UTC) #12
paulmeyer
4 years, 3 months ago (2016-08-31 19:09:55 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2300763002/ by paulmeyer@chromium.org.

The reason for reverting is: Suspected cause of
"virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html"
failures in webkit_tests on "WebKit Linux (dbg)" bot.

example:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg....

Powered by Google App Engine
This is Rietveld 408576698