third_party/WebKit/Source/core/html/HTMLOutputElement.cpp - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Added a layout test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp b/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

index f5a58d1b4d4a71f47e3dd0f6957c858b90b3259e..117151d50072efc7e2e05cb3ff22246f2c6337b1 100644

--- a/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLOutputElement.cpp

@@ -145,6 +145,10 @@ void HTMLOutputElement::setDefaultValue(const String& value)

setTextContent(value);

}

+short HTMLOutputElement::tabIndex() const

+ return -1;

tkent 2016/09/01 23:27:24 We should return HTMLElement::tabIndex().

lunalu1 2016/09/02 01:07:38 Done.

DEFINE_TRACE(HTMLOutputElement)

{