Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/extension_file_util.h

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments (icons-handler) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_file_util.h
diff --git a/chrome/common/extensions/extension_file_util.h b/chrome/common/extensions/extension_file_util.h
index 4a94687772565e6731b0b928f56ec8b3e42c6462..785513583066b2a4371ce886312d81834254764c 100644
--- a/chrome/common/extensions/extension_file_util.h
+++ b/chrome/common/extensions/extension_file_util.h
@@ -12,8 +12,6 @@
#include "base/memory/ref_counted.h"
#include "extensions/common/manifest.h"
-class ExtensionIconSet;
-
namespace base {
class DictionaryValue;
class FilePath;
@@ -62,16 +60,6 @@ scoped_refptr<extensions::Extension> LoadExtension(
base::DictionaryValue* LoadManifest(const base::FilePath& extension_root,
std::string* error);
-// Returns true if the given file path exists and is not zero-length.
-bool ValidateFilePath(const base::FilePath& path);
-
-// Returns true if the icons in the icon set exist. Oherwise, populates
-// |error| with the |error_message_id| for an invalid file.
-bool ValidateExtensionIconSet(const ExtensionIconSet& icon_set,
- const extensions::Extension* extension,
- int error_message_id,
- std::string* error);
-
// Returns true if the given extension object is valid and consistent.
// May also append a series of warning messages to |warnings|, but they
// should not prevent the extension from running.
« no previous file with comments | « chrome/common/extensions/chrome_manifest_handlers.cc ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698