Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 229813002: Move extensions manifest IconsHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments (icons-handler) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_file_util.cc
diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc
index fa7426bda390aef59c409540dde62f55a8a93635..89d2e0065c4030b527320f7c7f6516cebcdadea8 100644
--- a/chrome/common/extensions/extension_file_util.cc
+++ b/chrome/common/extensions/extension_file_util.cc
@@ -15,11 +15,9 @@
#include "base/metrics/histogram.h"
#include "base/path_service.h"
#include "base/strings/stringprintf.h"
-#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_restrictions.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/api/extension_action/action_info.h"
-#include "chrome/common/extensions/manifest_handlers/icons_handler.h"
#include "chrome/common/extensions/manifest_handlers/theme_handler.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
@@ -31,6 +29,7 @@
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handler.h"
+#include "extensions/common/manifest_handlers/icons_handler.h"
#include "grit/generated_resources.h"
#include "net/base/file_stream.h"
#include "ui/base/l10n/l10n_util.h"
@@ -223,35 +222,6 @@ std::vector<base::FilePath> FindPrivateKeyFiles(
return result;
}
-bool ValidateFilePath(const base::FilePath& path) {
- int64 size = 0;
- if (!base::PathExists(path) ||
- !base::GetFileSize(path, &size) ||
- size == 0) {
- return false;
- }
-
- return true;
-}
-
-bool ValidateExtensionIconSet(const ExtensionIconSet& icon_set,
- const Extension* extension,
- int error_message_id,
- std::string* error) {
- for (ExtensionIconSet::IconMap::const_iterator iter = icon_set.map().begin();
- iter != icon_set.map().end();
- ++iter) {
- const base::FilePath path =
- extension->GetResource(iter->second).GetFilePath();
- if (!ValidateFilePath(path)) {
- *error = l10n_util::GetStringFUTF8(error_message_id,
- base::UTF8ToUTF16(iter->second));
- return false;
- }
- }
- return true;
-}
-
bool ValidateExtension(const Extension* extension,
std::string* error,
std::vector<extensions::InstallWarning>* warnings) {
« no previous file with comments | « chrome/common/extensions/extension_file_util.h ('k') | chrome/common/extensions/manifest_handlers/icons_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698