Using input language instead of the application locale to determine the Omnibox's text input type o…

Using input language instead of the application locale to determine the Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would less likely to be abused.
2) Makes InputMethodBase to have empty implementations for OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834
Committed: https://crrev.com/f958e39a06d64450f0c2220bd44ac31ccbd289a6
Cr-Commit-Position: refs/heads/master@{#417189}

[Shu Chen, 2016-09-01 01:39:09]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 01:39:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:49:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2016-09-01 02:49:22]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 02:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 02:52:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Shu Chen, 2016-09-01 03:10:04]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 03:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 03:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 03:23:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Shu Chen, 2016-09-01 04:03:42]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 04:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 04:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 04:27:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2016-09-01 04:47:06]

Description was changed from

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

BUG=344834
==========

to

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would
less likely to be abused.
2) Makes InputMethodBase to have empty implementations for
OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834
==========

[Shu Chen, 2016-09-01 04:47:15]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 04:47:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shu Chen, 2016-09-01 05:53:32]

shuchen@chromium.org changed reviewers:
+ sky@chromium.org, yukawa@chromium.org

[Shu Chen, 2016-09-01 05:53:33]

yukawa@/sky@, can you please review this cl? Thanks!

yukawa@: the changes of InputMethodWin/IMM32Manager.

sky@: stamp for changes under chrome/browser/ui/views/... and ui/views/mus/...

[commit-bot: I haz the power, 2016-09-01 06:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:45:04]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2016-09-01 07:21:19]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 07:21:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 08:19:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 08:19:53]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-01 18:23:43]

LGTM

https://codereview.chromium.org/2298123003/diff/100001/ui/views/mus/input_met...
File ui/views/mus/input_method_mus.cc (left):

https://codereview.chromium.org/2298123003/diff/100001/ui/views/mus/input_met...
ui/views/mus/input_method_mus.cc:100: void
InputMethodMus::OnInputLocaleChanged() {
Leave this one here because of the TODO.

[yukawa, 2016-09-01 20:15:03]

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
File ui/base/ime/input_method_win.cc (right):

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
ui/base/ime/input_method_win.cc:269: void InputMethodWin::OnInputLocaleChanged()
{
We probably may want to add a TODO for this method somewhere.

  // Currently OnInputLocaleChanged on Windows relies on WM_INPUTLANGCHANGE,
  // which is known to be incompatible with TSF.
  // TODO: Use ITfLanguageProfileNotifySink instead.

See user comments on https://technet.microsoft.com/en-us/library/ms632629 for
details.

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
ui/base/ime/input_method_win.cc:270: // Note: OnInputLocaleChanged() is for
crbug.com/168971.
We may want to update this line because we basically abandoned crbug.com/168971.

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/win/imm32_...
File ui/base/ime/win/imm32_manager.cc (right):

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/win/imm32_...
ui/base/ime/win/imm32_manager.cc:134: ::GetKeyboardLayoutNameW(keyboard_layout);
Let's check the return value.  If |GetKeyboardLayoutNameW| failed for some
reasons, |_wtoi| could try to access uninitialized memory.

[Shu Chen, 2016-09-07 03:13:34]

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
File ui/base/ime/input_method_win.cc (right):

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
ui/base/ime/input_method_win.cc:269: void InputMethodWin::OnInputLocaleChanged()
{
On 2016/09/01 20:15:03, yukawa wrote:
> We probably may want to add a TODO for this method somewhere.
> 
>   // Currently OnInputLocaleChanged on Windows relies on WM_INPUTLANGCHANGE,
>   // which is known to be incompatible with TSF.
>   // TODO: Use ITfLanguageProfileNotifySink instead.
> 
> See user comments on https://technet.microsoft.com/en-us/library/ms632629 for
> details.

Done.

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/input_meth...
ui/base/ime/input_method_win.cc:270: // Note: OnInputLocaleChanged() is for
crbug.com/168971.
On 2016/09/01 20:15:03, yukawa wrote:
> We may want to update this line because we basically abandoned
crbug.com/168971.

Done.

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/win/imm32_...
File ui/base/ime/win/imm32_manager.cc (right):

https://codereview.chromium.org/2298123003/diff/100001/ui/base/ime/win/imm32_...
ui/base/ime/win/imm32_manager.cc:134: ::GetKeyboardLayoutNameW(keyboard_layout);
On 2016/09/01 20:15:03, yukawa wrote:
> Let's check the return value.  If |GetKeyboardLayoutNameW| failed for some
> reasons, |_wtoi| could try to access uninitialized memory.

Done.

https://codereview.chromium.org/2298123003/diff/100001/ui/views/mus/input_met...
File ui/views/mus/input_method_mus.cc (left):

https://codereview.chromium.org/2298123003/diff/100001/ui/views/mus/input_met...
ui/views/mus/input_method_mus.cc:100: void
InputMethodMus::OnInputLocaleChanged() {
On 2016/09/01 18:23:43, sky wrote:
> Leave this one here because of the TODO.

Done.

[yukawa, 2016-09-07 18:55:24]

lgtm

[Shu Chen, 2016-09-08 01:34:31]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-09-08 01:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2298123003/#ps120001
(title: "addressed comments.")

[commit-bot: I haz the power, 2016-09-08 01:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:47:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:47:57]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2016-09-08 02:33:10]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-09-08 02:33:10]

The patchset sent to the CQ was uploaded after l-g-t-m from yukawa@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2298123003/#ps140001
(title: "fix compiling errors in mus.")

[commit-bot: I haz the power, 2016-09-08 02:33:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 04:24:29]

Description was changed from

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would
less likely to be abused.
2) Makes InputMethodBase to have empty implementations for
OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834
==========

to

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would
less likely to be abused.
2) Makes InputMethodBase to have empty implementations for
OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834
==========

[commit-bot: I haz the power, 2016-09-08 04:24:30]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-08 04:26:08]

Description was changed from

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would
less likely to be abused.
2) Makes InputMethodBase to have empty implementations for
OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834
==========

to

==========
Using input language instead of the application locale to determine the
Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would
less likely to be abused.
2) Makes InputMethodBase to have empty implementations for
OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834

Committed: https://crrev.com/f958e39a06d64450f0c2220bd44ac31ccbd289a6
Cr-Commit-Position: refs/heads/master@{#417189}
==========

[commit-bot: I haz the power, 2016-09-08 04:26:09]

Patchset 8 (id:??) landed as
https://crrev.com/f958e39a06d64450f0c2220bd44ac31ccbd289a6
Cr-Commit-Position: refs/heads/master@{#417189}